Update vendor dependencies #221

humblec · 2020-04-02T05:12:15Z

Signed-off-by: Humble Chirammal [email protected]

Updated client-go to v0.18

k8s-ci-robot · 2020-04-02T05:12:23Z

Hi @humblec. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

humblec · 2020-04-02T05:49:27Z

/release-note-none
/ok-to-test

k8s-ci-robot · 2020-04-02T05:49:40Z

@humblec: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/release-note-none
/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Humble Chirammal <[email protected]>

jsafrane · 2020-04-02T07:50:13Z

/ok-to-test

pohly · 2020-04-02T07:51:51Z

go.mod

-	github.com/imdario/mergo v0.3.7 // indirect
+	github.com/golang/mock v1.4.3
+	github.com/golang/protobuf v1.3.5
+	github.com/imdario/mergo v0.3.9 // indirect
 	github.com/kubernetes-csi/csi-lib-utils v0.7.0
 	github.com/kubernetes-csi/csi-test v2.0.0+incompatible


Can you also update to csi-test v3.x?

Signed-off-by: Humble Chirammal <[email protected]>

humblec · 2020-04-03T15:43:47Z

@jsafrane @pohly looks like CI is passing now, I am removing WIP . However I have added ctx and other params to API call to satisfy the new func signature due to the dependency update. Please review ..

pohly

Looks good to me, but before we merge I'd like to hear from @msau42 or @xing-yang how we want to handle the transition to client-go 1.18: we have some shared libraries (https://github.com/kubernetes-csi/csi-lib-utils, https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner) which still use the older client-go API. Shall we update all repos after the next release?

msau42 · 2020-04-06T18:15:02Z

Yes, let's update all our repos to 1.18 client-go

humblec · 2020-04-06T19:34:22Z

kubernetes-sigs/sig-storage-lib-external-provisioner#73 cover s-s-l-external provisioner.

jsafrane · 2020-04-07T13:32:39Z

pkg/controller/util.go

 	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/client-go/kubernetes"
 	"k8s.io/klog"
 )

+var ctx context.Context = context.Background()


Please do not use global variables. Use context.TODO() in all places where you use this.
Or even better, find a good API server timeout and use that.

Sure, let me start with context.TODO() local variable. Will do a follow up PR for configurable timeout . thanks !

@jsafrane done.. changed to context.TODO() . .. @msau42 @pohly please review!

Signed-off-by: Humble Chirammal <[email protected]>

humblec · 2020-04-11T08:44:29Z

/assign @jsafrane
/assign @msau42
/assign @pohly

msau42 · 2020-04-13T19:40:59Z

/lgtm
/approve

This may be worth adding a release note since the client-go update was signficant. Please add one and then unhold
/hold

k8s-ci-robot · 2020-04-13T19:41:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2020-04-14T06:11:34Z

@humblec: the /release-note and /release-note-action-required commands have been deprecated.
Please edit the release-note block in the PR body text to include the release note. If the release note requires additional action include the string action required in the release note. For example:

```release-note
Some release note with action required.
```

In response to this:

/release-note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

humblec · 2020-04-14T06:13:02Z

@msau42 @pohly @jsafrane added release note . Please verify and unhold :).. thanks!

jsafrane · 2020-04-14T09:15:58Z

The release note is for end users (admins), who do not care about internals of golang API calls. IMO something like "Updated client-go to v0.18" would be sufficient.

humblec · 2020-04-14T12:02:45Z

The release note is for end users (admins), who do not care about internals of golang API calls. IMO something like "Updated client-go to v0.18" would be sufficient.

@sure.. done.. !

jsafrane · 2020-04-14T12:09:44Z

/hold cancel

jsafrane · 2020-04-14T17:49:08Z

Fixing failed travis by closing and reopening...

humblec · 2020-04-14T18:51:52Z

I was wondering why this was stuck.. thanks @jsafrane 👍

msau42 · 2020-04-14T19:02:55Z

travis is still stuck :( going to force merge. everything else is passing fine.

humblec · 2020-04-14T19:10:51Z

Thanks @jsafrane and @msau42 !!

6613c398 Merge pull request kubernetes-csi#223 from sunnylovestiramisu/update 0e7ae993 Update k8s image repo url 77e47cce Merge pull request kubernetes-csi#222 from xinydev/fix-dep-version 155854b0 Fix dep version mismatch 8f839056 Merge pull request kubernetes-csi#221 from sunnylovestiramisu/go-update 1d3f94dd Update go version to 1.20 to match k/k v1.27 e322ce5e Merge pull request kubernetes-csi#220 from andyzhangx/fix-golint-error b74a5120 test: fix golint error aa61bfd0 Merge pull request kubernetes-csi#218 from xing-yang/update_csi_driver 7563d196 Update CSI_PROW_DRIVER_VERSION to v1.11.0 a2171bef Merge pull request kubernetes-csi#216 from msau42/process cb987826 Merge pull request kubernetes-csi#217 from msau42/owners a11216e4 add new reviewers and remove inactive reviewers dd986754 Add step for checking builds b66c0824 Merge pull request kubernetes-csi#214 from pohly/junit-fixes b9b6763b filter-junit.go: fix loss of testcases when parsing Ginkgo v2 JUnit d4277839 filter-junit.go: preserve system error log 38e11468 prow.sh: publish individual JUnit files as separate artifacts git-subtree-dir: release-tools git-subtree-split: 6613c3980d1e418bebb7bc49d64c977cfff85671

k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 2, 2020

k8s-ci-robot requested review from jsafrane and sbezverk April 2, 2020 05:12

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 2, 2020

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 2, 2020

humblec force-pushed the contrib branch from 98a394f to 97743a4 Compare April 2, 2020 05:48

humblec changed the title ~~update kube dependency to v1.18.0~~ update vendor dependencies Apr 2, 2020

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 2, 2020

Update vendor dependencies to latest available version

37a4dfc

Signed-off-by: Humble Chirammal <[email protected]>

humblec force-pushed the contrib branch from 97743a4 to 37a4dfc Compare April 2, 2020 06:29

humblec changed the title ~~update vendor dependencies~~ [WIP] update vendor dependencies Apr 2, 2020

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2020

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 2, 2020

pohly reviewed Apr 2, 2020

View reviewed changes

humblec added 3 commits April 2, 2020 20:11

Update csi-test to v3.1.0

dc39a92

Signed-off-by: Humble Chirammal <[email protected]>

Update client-go to 0.18.0

86af41a

Signed-off-by: Humble Chirammal <[email protected]>

Update API calls with proper function signatures

7a7e1ca

Signed-off-by: Humble Chirammal <[email protected]>

humblec changed the title ~~[WIP] update vendor dependencies~~ Update vendor dependencies Apr 3, 2020

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2020

pohly approved these changes Apr 6, 2020

View reviewed changes

jsafrane reviewed Apr 7, 2020

View reviewed changes

Use context.TODO() instead of context.Background()

3db9346

Signed-off-by: Humble Chirammal <[email protected]>

k8s-ci-robot assigned jsafrane, msau42 and pohly Apr 11, 2020

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 13, 2020

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2020

jsafrane closed this Apr 14, 2020

jsafrane reopened this Apr 14, 2020

msau42 merged commit 37007dc into kubernetes-csi:master Apr 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update vendor dependencies #221

Update vendor dependencies #221

humblec commented Apr 2, 2020 •

edited

Loading

k8s-ci-robot commented Apr 2, 2020

humblec commented Apr 2, 2020

k8s-ci-robot commented Apr 2, 2020

jsafrane commented Apr 2, 2020

pohly Apr 2, 2020

humblec Apr 3, 2020

humblec commented Apr 3, 2020

pohly left a comment

msau42 commented Apr 6, 2020

humblec commented Apr 6, 2020 •

edited

Loading

jsafrane Apr 7, 2020

humblec Apr 8, 2020

humblec Apr 9, 2020

humblec commented Apr 11, 2020

msau42 commented Apr 13, 2020

k8s-ci-robot commented Apr 13, 2020

k8s-ci-robot commented Apr 14, 2020

humblec commented Apr 14, 2020

jsafrane commented Apr 14, 2020

humblec commented Apr 14, 2020

jsafrane commented Apr 14, 2020

jsafrane commented Apr 14, 2020

humblec commented Apr 14, 2020

msau42 commented Apr 14, 2020

humblec commented Apr 14, 2020

Update vendor dependencies #221

Update vendor dependencies #221

Conversation

humblec commented Apr 2, 2020 • edited Loading

k8s-ci-robot commented Apr 2, 2020

humblec commented Apr 2, 2020

k8s-ci-robot commented Apr 2, 2020

jsafrane commented Apr 2, 2020

pohly Apr 2, 2020

Choose a reason for hiding this comment

humblec Apr 3, 2020

Choose a reason for hiding this comment

humblec commented Apr 3, 2020

pohly left a comment

Choose a reason for hiding this comment

msau42 commented Apr 6, 2020

humblec commented Apr 6, 2020 • edited Loading

jsafrane Apr 7, 2020

Choose a reason for hiding this comment

humblec Apr 8, 2020

Choose a reason for hiding this comment

humblec Apr 9, 2020

Choose a reason for hiding this comment

humblec commented Apr 11, 2020

msau42 commented Apr 13, 2020

k8s-ci-robot commented Apr 13, 2020

k8s-ci-robot commented Apr 14, 2020

humblec commented Apr 14, 2020

jsafrane commented Apr 14, 2020

humblec commented Apr 14, 2020

jsafrane commented Apr 14, 2020

jsafrane commented Apr 14, 2020

humblec commented Apr 14, 2020

msau42 commented Apr 14, 2020

humblec commented Apr 14, 2020

humblec commented Apr 2, 2020 •

edited

Loading

humblec commented Apr 6, 2020 •

edited

Loading